[webkit-reviews] review granted: [Bug 36723] Crash while uploading a PDF document on www.largefilesasap.com : [Attachment 52123] Patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has granted TAMURA, Kent
<tkent at chromium.org>'s request for review:
Bug 36723: Crash while uploading a PDF document on www.largefilesasap.com
https://bugs.webkit.org/show_bug.cgi?id=36723

Attachment 52123: Patch
https://bugs.webkit.org/attachment.cgi?id=52123&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>

> @@ -44,7 +45,7 @@ public:
>      virtual void repaint() = 0;
>      virtual bool allowsMultipleFiles() = 0;
>      virtual String acceptTypes() = 0;
> -    virtual void chooseIconForFiles(const Vector<String>&) = 0;
> +    virtual void chooseIconForFiles(FileChooser*, const Vector<String>&) =
0;
>      virtual ~FileChooserClient();
>  };
>  

This is a better change, anyways - we like telling clients which object it is
they're working on, because one object can be the client for multiple
clientees.

r+!