[webkit-reviews] review denied: [Bug 36723] Crash while uploading a PDF document on www.largefilesasap.com : [Attachment 52122] Patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has denied TAMURA, Kent <tkent at chromium.org>'s
request for review:
Bug 36723: Crash while uploading a PDF document on www.largefilesasap.com
https://bugs.webkit.org/show_bug.cgi?id=36723

Attachment 52122: Patch
https://bugs.webkit.org/attachment.cgi?id=52122&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>

> -	   m_client->chooseIconForFiles(m_filenames);
> +	   m_client->chooseIconForFiles(*this, m_filenames);

> -    virtual void chooseIconForFiles(const Vector<String>&) = 0;
> +    virtual void chooseIconForFiles(FileChooser&, const Vector<String>&) =
0;
>      virtual ~FileChooserClient();
>

> -void RenderFileUploadControl::chooseIconForFiles(const Vector<String>&
filenames)
> +void RenderFileUploadControl::chooseIconForFiles(FileChooser& chooser, const
Vector<String>& filenames)
>  {
>      if (Chrome* chromePointer = chrome())
> -	   chromePointer->chooseIconForFiles(filenames, m_fileChooser);
> +	   chromePointer->chooseIconForFiles(filenames, &chooser);

> -    void chooseIconForFiles(const Vector<String>&);
> +    void chooseIconForFiles(FileChooser&, const Vector<String>&);

We normally only use references for values stack values, and I'm not aware of
anywhere where we use them for heap-only objects.

This really can be a raw pointer:
void chooseIconForFiles(FileChooser*, const Vector<String>&);