[webkit-reviews] review granted: [Bug 36245] rebaseline_chromium_webkit_test.py should fallback to debug if release image diff does not exist : [Attachment 52098] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 30 16:54:07 PDT 2010


Eric Seidel <eric at webkit.org> has granted Victor Wang <victorw at chromium.org>'s
request for review:
Bug 36245: rebaseline_chromium_webkit_test.py should fallback to debug if
release image diff does not exist
https://bugs.webkit.org/show_bug.cgi?id=36245

Attachment 52098: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=52098&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Please document the arguments in:
 1011	  if not port_obj.check_image_diff(None, False):
by naming them in the callsite.

Otherwise this looks OK.


More information about the webkit-reviews mailing list