[webkit-reviews] review denied: [Bug 36781] Enable fast/events/onbeforeunload-focused-iframe.html for Chromium : [Attachment 52091] Proposed fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 30 15:58:44 PDT 2010


David Levin <levin at chromium.org> has denied Sterling Swigart
<sswigart at google.com>'s request for review:
Bug 36781: Enable fast/events/onbeforeunload-focused-iframe.html for Chromium
https://bugs.webkit.org/show_bug.cgi?id=36781

Attachment 52091: Proposed fix
https://bugs.webkit.org/attachment.cgi?id=52091&action=review

------- Additional Comments from David Levin <levin at chromium.org>
> diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
> +	   * platform/chromium/test_expectations.txt: Enable test now that
callShouldCloseOnWebView
> +	is implemented in test_shell.

This is great except for the TAB here.

Please get rid of it and upload and I'll r+,cq+ it for you.


More information about the webkit-reviews mailing list