[webkit-reviews] review requested: [Bug 36245] Add option "target" to rebaseline_chromium_webkit_test.py : [Attachment 52088] Proposed patch

[bugzilla-daemon at webkit.org]

Victor Wang <victorw at chromium.org> has asked  for review:
Bug 36245: Add option "target" to rebaseline_chromium_webkit_test.py
https://bugs.webkit.org/show_bug.cgi?id=36245

Attachment 52088: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=52088&action=review

------- Additional Comments from Victor Wang <victorw at chromium.org>
Updated check_build to re-use the image check port.

Eric,
Figuring out whether image diff exists and setting the target (if it is empty)
based
on the result is kind of rebaseline tool specific so I agree with Dirk here on
not having
these logics inside port object. let me know if you disagree and strongly
prefer
we should move these logics into port.