[webkit-reviews] review granted: [Bug 36830] IndexedDB: Finish hooking up bindings for IndexedDatabaseRequest : [Attachment 52044] Patch

[bugzilla-daemon at webkit.org]

Nate Chapin <japhet at chromium.org> has granted Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 36830: IndexedDB: Finish hooking up bindings for IndexedDatabaseRequest
https://bugs.webkit.org/show_bug.cgi?id=36830

Attachment 52044: Patch
https://bugs.webkit.org/attachment.cgi?id=52044&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
r+ with a nit.

> +private:
> +    V8CustomIDBCallbacks(v8::Local<v8::Value> onSuccess,
v8::Local<v8::Value> onError, Frame* frame)
> +	   : m_onSuccessNull(!onSuccess->IsObject())
> +	   ,
m_onSuccess(v8::Persistent<v8::Object>::New(onSuccess->ToObject()))
> +	   , m_onErrorNull(!onError->IsObject())
> +	   , m_onError(v8::Persistent<v8::Object>::New(onError->ToObject()))
> +	   , m_frame(frame)
> +    {
> +    }
> +
> +    // FIXME: Should these be v8::Functions?  For some reason, VoidCallback
(which this copied) uses v8::Objects.
> +    bool m_onSuccessNull;
> +    v8::Persistent<v8::Object> m_onSuccess;
> +    bool m_onErrorNull;

Why do we need separate bools here?  It seems like unnecessary duplication of
information to me.

> +    v8::Persistent<v8::Object> m_onError;
> +    RefPtr<Frame> m_frame;
> +};
> +
> +}
> +
> +#endif
> +
> +#endif // V8CustomIDBCallbacks_h