[webkit-reviews] review granted: [Bug 36466] audio engine: add Reverb class : [Attachment 51976] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 30 07:33:10 PDT 2010


Jeremy Orlow <jorlow at chromium.org> has granted Chris Rogers
<crogers at google.com>'s request for review:
Bug 36466: audio engine: add Reverb class
https://bugs.webkit.org/show_bug.cgi?id=36466

Attachment 51976: Patch
https://bugs.webkit.org/attachment.cgi?id=51976&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
r=me, but as with the other engine patches, this should go into the branch.


> +void Reverb::process(AudioBus* sourceBus, AudioBus* destinationBus, size_t
framesToProcess)
> +{
> +    // Do a fairly comprehensive sanity check.
> +    // If these conditions are satisfied, all of the source and destination
pointers will be valid for the various matrixing cases.
> +    bool isSafeToProcess = sourceBus && destinationBus &&
sourceBus->numberOfChannels() > 0 && destinationBus->numberOfChannels() > 0
> +	   && framesToProcess <= MaxFrameSize && framesToProcess <=
sourceBus->frameSize() && framesToProcess <= destinationBus->frameSize(); 

nit: probably better to line up on |sourceBus|

i.e.

    bool isSafeToProcess = sourceBus && destinationBus &&
sourceBus->numberOfChannels() > 0 && destinationBus->numberOfChannels() > 0
			   && framesToProcess <= MaxFrameSize &&
framesToProcess <= sourceBus->frameSize() && framesToProcess <=
destinationBus->frameSize();


More information about the webkit-reviews mailing list