[webkit-reviews] review denied: [Bug 35607] Allow building smoothly on win32 and win64 using GCC : [Attachment 51718] patch with fixes required by QtWebkit for mingw64 - JavaScriptCore

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 30 03:36:38 PDT 2010


Oliver Hunt <oliver at apple.com> has denied vanboxem.ruben at gmail.com's request
for review:
Bug 35607: Allow building smoothly on win32 and win64 using GCC
https://bugs.webkit.org/show_bug.cgi?id=35607

Attachment 51718: patch with fixes required by QtWebkit for mingw64 -
JavaScriptCore
https://bugs.webkit.org/attachment.cgi?id=51718&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
no space after # in preprocessor directives, no space before the ('s either --
for nesting preprocessor directives we indent the entire line, not the content
after the #

Otherwise looks fine


More information about the webkit-reviews mailing list