[webkit-reviews] review granted: [Bug 21371] Cannot animate "points" attribute for <svg:polygon> : [Attachment 51885] Patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Dirk Schulze
<krit at webkit.org>'s request for review:
Bug 21371: Cannot animate "points" attribute for <svg:polygon>
https://bugs.webkit.org/show_bug.cgi?id=21371

Attachment 51885: Patch
https://bugs.webkit.org/attachment.cgi?id=51885&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Nice patch, some small comments before landing:

> Index: WebCore/svg/SVGPathSegList.h
> ===================================================================
> --- WebCore/svg/SVGPathSegList.h	(revision 56693)
> +++ WebCore/svg/SVGPathSegList.h	(working copy)
> @@ -45,6 +45,8 @@ namespace WebCore {
>	   SVGPathSegList(const QualifiedName&);
>      };
>  
> +    float blendFunc(float from, float to, float progress);

Can you rename this function to something more descriptive?



> Index: WebCore/svg/SVGPointList.cpp

> +	   const FloatPoint from = fromList->getItem(n, ec);
> +	   const FloatPoint to = toList->getItem(n, ec);
Can't you omit const here?

Excellent testcase, r=me.