[webkit-reviews] review denied: [Bug 36695] SVG Animation doesn't respect 'currentColor' : [Attachment 51833] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 30 00:51:11 PDT 2010


Nikolas Zimmermann <zimmermann at kde.org> has denied Dirk Schulze
<krit at webkit.org>'s request for review:
Bug 36695: SVG Animation doesn't respect 'currentColor'
https://bugs.webkit.org/show_bug.cgi?id=36695

Attachment 51833: Patch
https://bugs.webkit.org/attachment.cgi?id=51833&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Patch looks fine, the test is flawed though.
New SVG animation tests (not part of SVG 1.1 testsuite) need to go into
svg/animations and need to be implemented using the SVG animation specific DRT
commands, sampling the animation values at certain times.
When running your new test through DRT, the animation is not executed at all -
the png even reflects this, as only one green rects is shown.

Happy to review the follow-up :-)


More information about the webkit-reviews mailing list