[webkit-reviews] review denied: [Bug 36698] There is a build break due to the disabled() when wml is enabled. : [Attachment 52005] Patch for a build break due to the disabled() function
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 29 23:14:26 PDT 2010
Eric Seidel <eric at webkit.org> has denied review:
Bug 36698: There is a build break due to the disabled() when wml is enabled.
https://bugs.webkit.org/show_bug.cgi?id=36698
Attachment 52005: Patch for a build break due to the disabled() function
https://bugs.webkit.org/attachment.cgi?id=52005&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
Actually, looks like you modified the "reviewed by" line:
+ Reviewed by NOBODY(OOPS!).
the default template is:
+ Reviewed by NOBODY (OOPS!).
The scripts aren't smart enough to know the difference between "NOBODY(OOPS!)"
and an intentionally specified reviewer.
I suggest just regenerating the ChangeLog from prepare-ChangeLog, which will
both fix your reviewed by line to be the default as well as add the information
about WebCore/wml/WMLSelectElement.h
Sorry our scripts are so troublesome.
More information about the webkit-reviews
mailing list