[webkit-reviews] review requested: [Bug 36698] There is a build break due to the disabled() when wml is enabled. : [Attachment 52005] Patch for a build break due to the disabled() function
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 29 22:35:18 PDT 2010
Gyuyoung Kim <gyuyoung.kim at samsung.com> has asked for review:
Bug 36698: There is a build break due to the disabled() when wml is enabled.
https://bugs.webkit.org/show_bug.cgi?id=36698
Attachment 52005: Patch for a build break due to the disabled() function
https://bugs.webkit.org/attachment.cgi?id=52005&action=review
------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
Sorry for my frequent patches, I am not good at making a patch yet.
I found one more build break because of Bug 36177 - Multiselect Popup -
Listbox click simulation.
(https://bugs.webkit.org/show_bug.cgi?id=36177)
The patch add a virtual function to SelectElement.h as below,
virtual void listBoxSelectItem(int listIndex, bool allowMultiplySelections,
bool shift, bool fireOnChangeNow = true) = 0;
It seems the patch of bug didn't consider wml. I add a virtual function to
WMLSelectElement.h.
More information about the webkit-reviews
mailing list