[webkit-reviews] review requested: [Bug 36771] new-run-webkit-tests shouldn't report "unexpected passes" when pixel tests are disabled : [Attachment 51996] update after more feedback from eseidel
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 29 19:34:53 PDT 2010
Dirk Pranke <dpranke at chromium.org> has asked for review:
Bug 36771: new-run-webkit-tests shouldn't report "unexpected passes" when pixel
tests are disabled
https://bugs.webkit.org/show_bug.cgi?id=36771
Attachment 51996: update after more feedback from eseidel
https://bugs.webkit.org/attachment.cgi?id=51996&action=review
------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
Okay, I'm adopting a different approach here. We'll keep as much of the logic
in test_expectations as possible, but make the decision of how to handle pixel
test failures passed in from run_webkit_tests.
Also, I've split the logic out into separate testable pure function calls, and
added more unit tests.
More information about the webkit-reviews
mailing list