[webkit-reviews] review requested: [Bug 36698] There is a build break due to the disabled() when wml is enabled. : [Attachment 51993] Patch for a build break due to the disabled() function

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at samsung.com> has asked  for review:
Bug 36698: There is a build break due to the disabled() when wml is enabled.
https://bugs.webkit.org/show_bug.cgi?id=36698

Attachment 51993:  Patch for a build break due to the disabled() function 
https://bugs.webkit.org/attachment.cgi?id=51993&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
When wml feature is enabled, there is a build break as below,

------------------------------------------------------------------------------
DerivedSources/WMLElementFactory.cpp: In function
‘WTF::PassRefPtr<WebCore::WMLElement> WebCore::optionConstructor(const
WebCore::QualifiedName&, WebCore::Document*, bool)’:
DerivedSources/WMLElementFactory.cpp:154: error: cannot allocate an object of
abstract type ‘WebCore::WMLOptionElement’
./WebCore/wml/WMLOptionElement.h:31: note:   because the following virtual
functions are pure within ‘WebCore::WMLOptionElement’:
./WebCore/dom/OptionElement.h:37: note:     virtual bool
WebCore::OptionElement::disabled() const
DerivedSources/WMLElementFactory.cpp: In function
‘WTF::PassRefPtr<WebCore::WMLElement> WebCore::selectConstructor(const
WebCore::QualifiedName&, WebCore::Document*, bool)’:
DerivedSources/WMLElementFactory.cpp:179: error: cannot allocate an object of
abstract type ‘WebCore::WMLSelectElement’
./WebCore/wml/WMLSelectElement.h:30: note:   because the following virtual
functions are pure within ‘WebCore::WMLSelectElement’:
./WebCore/dom/SelectElement.h:64: note:     virtual void
WebCore::SelectElement::listBoxSelectItem(int, bool, bool, bool)
------------------------------------------------------------------------------

I didn't check if the WML behavior is wrong. But, I think we need to avoid a
build break for now.
I will report if WML option elements can't be disabled or not again. If I am
wrong, please let me know. 

Thank you.