[webkit-reviews] review denied: [Bug 26224] [Qt, Gtk] Allows build-webkit script to receive an install prefix as parameter : [Attachment 51921] Updated patch to match the webkit requirements as requested by Antonio Gomes.

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied Rodrigo Belem
<rclbelem at gmail.com>'s request for review:
Bug 26224: [Qt, Gtk] Allows build-webkit script to receive an install prefix as
parameter
https://bugs.webkit.org/show_bug.cgi?id=26224

Attachment 51921: Updated patch to match the webkit requirements as requested
by Antonio Gomes.
https://bugs.webkit.org/attachment.cgi?id=51921&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
 2841	      headers.path = $$INSTALL_PREFIX/include/qt4/QtWebKit
 2842	target.path = $$INSTALL_PREFIX/lib

This seems to be indented poorly. Tabs?

 222   --prefix=<PREFIX>		 Install files in PREFIX
221223	 --makeargs=<arguments> 	   Optional Makefile flags

--makeargs uses a lower-cased argument place-holder, perhaps we should keep
this consistent. You could use <path>, for instance. This still misses an
indication that this only affects some ports, I think.

Except for these two nits, the GTK+ part of it looks good to me. I'll r- since
you're not a committer, and we'll need an updated patch anyway. If someone
wants to look at the Qt changes, and say r+ when these nits are addressed, the
GTK+ side looks good, like I said =).