[webkit-reviews] review requested: [Bug 25756] Explicit guards for ENABLE_GEOLOCATION : [Attachment 51953] fix ChangeLog

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 29 12:58:40 PDT 2010


Laszlo Gombos <laszlo.1.gombos at nokia.com> has asked  for review:
Bug 25756: Explicit guards for ENABLE_GEOLOCATION
https://bugs.webkit.org/show_bug.cgi?id=25756

Attachment 51953: fix ChangeLog
https://bugs.webkit.org/attachment.cgi?id=51953&action=review

------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
Thanks for the review, David. I fixed the ChangeLog.

I considered your suggestion of moving stub implementation is in the header
file; however I think that would mean that those symbols could not not get
exported. I was trying to minimize the impact on clients, so that a stub symbol
is still exported for most symbols. For example Geolocation::setIsAllowed() is
still listed in WebCore.base.exp.

Moving those symbols to the header would mean moving some more symbols over to
WebCore.Geolocation.exp and making more changes under WebKit/mac. I'm happy to
make those changes if that is the direction we want to take this patch.

For now, I just resubmitted the patch with only changes in the ChangeLog.


More information about the webkit-reviews mailing list