[webkit-reviews] review granted: [Bug 36759] check-webkit-style: Eliminate explicit slash characters from _rel_path() : [Attachment 51922] Proposed patch

[bugzilla-daemon at webkit.org]

Shinichiro Hamaji <hamaji at chromium.org> has granted Chris Jerdonek
<cjerdonek at webkit.org>'s request for review:
Bug 36759: check-webkit-style: Eliminate explicit slash characters from
_rel_path()
https://bugs.webkit.org/show_bug.cgi?id=36759

Attachment 51922: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=51922&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
> -    if rel_path and rel_path[0] not in slash_chars:
> -	   # Then we are in the case typified by the following example:
> +    if not rel_path:
> +	   # Then the paths are the same.
> +	   pass

Ah, this patch let me notice we cannot run check-webkit-style with the root
checkout directory

% ./WebKitTools/Scripts/check-webkit-style `pwd`  # in WebKit checkout
directory
File not a recognized type to check. Skipping: ""
Total errors found: 0 in 1 files

and

% ./WebKitTools/Scripts/check-webkit-style .  # in WebKit checkout directory
File not a recognized type to check. Skipping: ""
Total errors found: 0 in 1 files

But this would be another issue. Let's go ahead as is.