[webkit-reviews] review granted: [Bug 31680] WebCore::Document::updateLayoutIgnorePendingStylesheets NULL pointer : [Attachment 51880] v1; guarded null document

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted MORITA Hajime <morrita at google.com>'s
request for review:
Bug 31680: WebCore::Document::updateLayoutIgnorePendingStylesheets NULL pointer
https://bugs.webkit.org/show_bug.cgi?id=31680

Attachment 51880: v1; guarded null document
https://bugs.webkit.org/attachment.cgi?id=51880&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
The fact that DocumentType nodes have no document stinks. The question is where
to guard against these types of nodes. To me, canonicalPosition seems a bit
low-level a place to be doing the check. I worry there are other leaf functions
that lack this. It might be better to guard this incoming at places where nodes
are passed in.

r=me, though