[webkit-reviews] review granted: [Bug 36737] Eliminate use of GL_BGRA in GraphicsContext3DSkia.cpp : [Attachment 51874] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Kenneth Russell
<kbr at google.com>'s request for review:
Bug 36737: Eliminate use of GL_BGRA in GraphicsContext3DSkia.cpp
https://bugs.webkit.org/show_bug.cgi?id=36737

Attachment 51874: Patch
https://bugs.webkit.org/attachment.cgi?id=51874&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebCore/platform/graphics/skia/GraphicsContext3DSkia.cpp
> +    // FIXME: add GL_BGRA extension support
> +    for (int i = 0; i < size; i += 4)
> +	   std::swap(outputVector[i], outputVector[i + 2]);
> +    *format = RGBA;
>      return true;
>  }

^^^ it would be nice to add a comment above the loop explaining
that you are converting from BGRA to RGBA.

r=me with such a comment