[webkit-reviews] review denied: [Bug 36692] Redo the file:// origin separation : [Attachment 51876] Address comments.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 29 00:16:33 PDT 2010
Adam Barth <abarth at webkit.org> has denied Chris Evans <scarybeasts at gmail.com>'s
request for review:
Bug 36692: Redo the file:// origin separation
https://bugs.webkit.org/show_bug.cgi?id=36692
Attachment 51876: Address comments.
https://bugs.webkit.org/attachment.cgi?id=51876&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
+ if (m_protocol == "file") {
+ String str("file://");
+ if (m_enforceFilePathSeparation)
+ str += m_filePath;
This code is still wrong. As I said above, this value is exposed to web
content and we can't just go changing it. Making the code conditional on
m_enforceFilePathSeparation doesn't solve the problem of giving providing the
wrong string to JavaScript.
More information about the webkit-reviews
mailing list