[webkit-reviews] review denied: [Bug 25756] Explicit guards for ENABLE_GEOLOCATION : [Attachment 51798] re-baseline previous patch

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has denied Laszlo Gombos
<laszlo.1.gombos at nokia.com>'s request for review:
Bug 25756: Explicit guards for ENABLE_GEOLOCATION
https://bugs.webkit.org/show_bug.cgi?id=25756

Attachment 51798: re-baseline previous patch
https://bugs.webkit.org/attachment.cgi?id=51798&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
> +2010-03-26  Laszlo Gombos  <laszlo.1.gombos at nokia.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Guard Geolocation files with ENABLE_GEOLOCATION
> +	   https://bugs.webkit.org/show_bug.cgi?id=25756
> +
> +	   The intent is to guard the Geolocation implementation files 
> +	   and minimize the impact on 

This seems like an incomplete sentence?

> Index: WebCore/page/Geolocation.cpp
> ===================================================================
> --- WebCore/page/Geolocation.cpp	(revision 56641)
> +++ WebCore/page/Geolocation.cpp	(working copy)
> @@ -28,6 +28,8 @@
>  #include "config.h"
>  #include "Geolocation.h"
>  
> +#if ENABLE(GEOLOCATION)
> +
>  #include "Chrome.h"
>  #include "Frame.h"
>  #include "Page.h"
> @@ -641,3 +643,19 @@ void Geolocation::stopUpdating()
>  }
>  
>  } // namespace WebCore
> +
> +#else
> +
> +namespace WebCore {
> +
> +void Geolocation::disconnectFrame() {}
> +
> +Geolocation::Geolocation(Frame*) {}
> +
> +Geolocation::~Geolocation() {}
> +
> +void Geolocation::setIsAllowed(bool) {}
> +
> +}
> +							   
> +#endif // ENABLE(GEOLOCATION)

I think the preferred place for the stub implementation is in the header file
(Geolocation.h) so that the whole thing can be inlined and optimized out by the
compiler.

r- to move the stub implementation into the header and fix the ChangeLog entry.
 Otherwise this looks great!