[webkit-reviews] review requested: [Bug 35163] autoinstall: should unzip downloaded zip and gzip files prior to importing : [Attachment 51875] Proposed patch 5

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Mar 28 19:40:53 PDT 2010


Chris Jerdonek <cjerdonek at webkit.org> has asked  for review:
Bug 35163: autoinstall: should unzip downloaded zip and gzip files prior to
importing
https://bugs.webkit.org/show_bug.cgi?id=35163

Attachment 51875: Proposed patch 5
https://bugs.webkit.org/attachment.cgi?id=51875&action=review

------- Additional Comments from Chris Jerdonek <cjerdonek at webkit.org>
It's been a while since patch 4 was rolled out due to an incompatibility with
Python 2.5.  I was waiting for us to settle the versioning stuff and most of
the re-organization before submitting an update.

The only substantive change here is writing a replacement for Python 2.6's
extract_all method.  I also improved the log messages and  the information that
renders when an error is raised.

After this lands, we'll be able to re-land the pep8 patch with essentially no
change (just rebasing):

https://bugs.webkit.org/show_bug.cgi?id=33639

Thanks.


More information about the webkit-reviews mailing list