[webkit-reviews] review denied: [Bug 36693] [Qt] Baseline accessibility support for QtWebKit : [Attachment 51813] previous patch + fix style
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Mar 28 14:21:26 PDT 2010
Simon Hausmann <hausmann at webkit.org> has denied Laszlo Gombos
<laszlo.1.gombos at nokia.com>'s request for review:
Bug 36693: [Qt] Baseline accessibility support for QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=36693
Attachment 51813: previous patch + fix style
https://bugs.webkit.org/attachment.cgi?id=51813&action=review
------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
> @@ -566,6 +568,8 @@ protected:
> AtkObject* m_wrapper;
> #elif PLATFORM(CHROMIUM)
> RefPtr<AccessibilityObjectWrapper> m_wrapper;
> +#elif PLATFORM(QT)
> + RefPtr<AccessibilityObjectWrapper> m_wrapper;
> #endif
Why not reuse the chromium preprocessor branch? :)
> Index: WebCore/accessibility/qt/AccessibilityObjectQt.cpp
> ===================================================================
> --- WebCore/accessibility/qt/AccessibilityObjectQt.cpp (revision
56652)
> +++ WebCore/accessibility/qt/AccessibilityObjectQt.cpp (working copy)
> @@ -1,5 +1,6 @@
> /*
> * Copyright (C) 2008 Apple Ltd.
> + * Copyright (C) 2010 Nokia Inc. All rights reserved.
> *
> * This library is free software; you can redistribute it and/or
> * modify it under the terms of the GNU Library General Public
It seems odd to me to add a copyright clase without adding any content that
_is_ copyrightable.
> Index: WebKitTools/DumpRenderTree/AccessibilityUIElement.cpp
> ===================================================================
> --- WebKitTools/DumpRenderTree/AccessibilityUIElement.cpp (revision
56652)
> +++ WebKitTools/DumpRenderTree/AccessibilityUIElement.cpp (working copy)
> @@ -28,6 +28,8 @@
>
> #include <JavaScriptCore/JSRetainPtr.h>
>
> +#include <limits.h>
> +
> // Static Functions
>
Why is this inclusion needed?
> -HEADERS = $$BASEDIR/WorkQueue.h \
> +HEADERS = \
> + $$BASEDIR/AccessibilityController.h \
> + $$BASEDIR/AccessibilityUIElement.h \
> + $$BASEDIR/WorkQueue.h \
> DumpRenderTreeQt.h \
> EventSenderQt.h \
> TextInputControllerQt.h \
> @@ -29,8 +32,14 @@ HEADERS = $$BASEDIR/WorkQueue.h \
> LayoutTestControllerQt.h \
> GCControllerQt.h \
> testplugin.h
> -SOURCES = ../../../JavaScriptCore/wtf/Assertions.cpp \
> +
> +SOURCES = \
> + ../../../JavaScriptCore/wtf/Assertions.cpp \
> + $$BASEDIR/AccessibilityController.cpp \
> + $$BASEDIR/AccessibilityUIElement.cpp \
> $$BASEDIR/WorkQueue.cpp \
> + AccessibilityControllerQt.cpp \
> + AccessibilityUIElementQt.cpp \
I doubt that this approach is going to work at all at this point, as the newly
added files require the JSC C API to actually work in the DRT. However there is
no JSContextRef available within the Qt DRT.
More information about the webkit-reviews
mailing list