[webkit-reviews] review granted: [Bug 36395] [Qt] Patch to add support for Content-Disposition... : [Attachment 51644] Updated Content-Disposition patch IV

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted adawit at kde.org's request for
review:
Bug 36395: [Qt] Patch to add support for Content-Disposition...
https://bugs.webkit.org/show_bug.cgi?id=36395

Attachment 51644: Updated Content-Disposition patch IV
https://bugs.webkit.org/attachment.cgi?id=51644&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
Patch looks good to me, but before landing we have to preserve Google's
copyright when moving the function!

Also we still don't have a test for this :-(

Dawit, do you want to follow up with a patch that removes the original from
WebKit/chromium and makes it use the new function from WebCore?

The build bots may help to make sure that your patch actually builds on
chromium.