[webkit-reviews] review denied: [Bug 32442] REGRESSION (r47686-r48034): Inspector console outputs the global value for a variable instead of the local value : [Attachment 51845] Proposed fix v1.0

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Dmitry Gorbik
<socket.h at gmail.com>'s request for review:
Bug 32442: REGRESSION (r47686-r48034): Inspector console outputs the global
value for a variable instead of the local value
https://bugs.webkit.org/show_bug.cgi?id=32442

Attachment 51845: Proposed fix v1.0
https://bugs.webkit.org/attachment.cgi?id=51845&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
Looks great! One nit and we can land this!

> +    if (!dontUseCommandLineAPI) {
> +	   expression = "with (window.console._inspectorCommandLineAPI) { with
(window) {\n" + expression + "\n} }";
> +    }

Single-line conditions should not have {}.