[webkit-reviews] review requested: [Bug 36696] scm_unittest: Get the SVNTest.test_svn_apply() unit test working again : [Attachment 51831] Proposed patch 2

[bugzilla-daemon at webkit.org]

Chris Jerdonek <cjerdonek at webkit.org> has asked  for review:
Bug 36696: scm_unittest: Get the SVNTest.test_svn_apply() unit test working
again
https://bugs.webkit.org/show_bug.cgi?id=36696

Attachment 51831: Proposed patch 2
https://bugs.webkit.org/attachment.cgi?id=51831&action=review

------- Additional Comments from Chris Jerdonek <cjerdonek at webkit.org>
Yeah, just needed to use the Committer class in _create_patch().  Thanks for
that.

By the way, something seems a bit hard to use about the Attachment class in
that the constructor accepts an attachment dictionary rather than a Committer
instance, etc.	It seems like it might be better if the constructor were more
traditional and a factory method were used for the dictionary route.