[webkit-reviews] review requested: [Bug 36698] There is a build break due to the disabled() when wml is enabled. : [Attachment 51823] Patch for a build break due to the disabled() funciton

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at samsung.com> has asked  for review:
Bug 36698: There is a build break due to the disabled() when wml is enabled.
https://bugs.webkit.org/show_bug.cgi?id=36698

Attachment 51823: Patch for a build break due to the disabled() funciton
https://bugs.webkit.org/attachment.cgi?id=51823&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
There is a build break due to the disabled() when wml is enabled. It seems that
this break comes from the Bug 35056 - Disabled menu options are still
submitted. 

WMLOptionElement class is a child class of OptionElement class as below. So, if
a virtual function is added to OptionElement, WMLOptionElement class should
defines that function as well.

  class WMLOptionElement : public WMLFormControlElement, public
WMLEventHandlingElement, public OptionElement {



My modification is as below,

--- WebCore/wml/WMLOptionElement.h	(revision 56658)
+++ WebCore/wml/WMLOptionElement.h	(working copy)
@@ -41,6 +41,8 @@ public:
     virtual void childrenChanged(bool changedByParser = false, Node*
beforeChange = 0, Node* afterChange = 0, int childCountDelta = 0);
     virtual void parseMappedAttribute(MappedAttribute*);

+    virtual bool disabled() const { return false; };
+

I think diabled() should be added to WMLOptionElement.h.

Thank you,
Gyuyoung Kim.