[webkit-reviews] review requested: [Bug 36696] scm_unittest: Get the SVNTest.test_svn_apply() unit test working again : [Attachment 51820] Proposed patch

[bugzilla-daemon at webkit.org]

Chris Jerdonek <cjerdonek at webkit.org> has asked  for review:
Bug 36696: scm_unittest: Get the SVNTest.test_svn_apply() unit test working
again
https://bugs.webkit.org/show_bug.cgi?id=36696

Attachment 51820: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=51820&action=review

------- Additional Comments from Chris Jerdonek <cjerdonek at webkit.org>
After this patch, this is the only failing "test-webkitpy --all" unit test:

FAIL: test_sheriff_bot
(webkitpy.tool.commands.sheriffbot_unittest.SheriffBotTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File
"/Users/chris_g4/dev/apple/WebKit-git/WebKitTools/Scripts/webkitpy/tool/command
s/sheriffbot_unittest.py", line 47, in test_sheriff_bot
    self.assert_queue_outputs(SheriffBot(), work_item=mock_work_item,
expected_stderr=expected_stderr)
  File
"/Users/chris_g4/dev/apple/WebKit-git/WebKitTools/Scripts/webkitpy/tool/command
s/queuestest.py", line 78, in assert_queue_outputs
    expected_stderr=expected_stderr.get("begin_work_queue", ""))
  File
"/Users/chris_g4/dev/apple/WebKit-git/WebKitTools/Scripts/webkitpy/common/syste
m/outputcapture.py", line 60, in assert_outputs
    testcase.assertEqual(stderr_string, expected_stderr)
AssertionError: 'CAUTION: sheriff-bot will discard all local changes in
"/private/tmp"\nRunning WebKit sheriff-bot.\n' != 'CAUTION: sheriff-bot will
discard all local changes in "/Users/chris_g4/dev/apple/WebKit-git"\nRunning
WebKit sheriff-bot.\n'