[webkit-reviews] review denied: [Bug 36692] Redo the file:// origin separation : [Attachment 51809] Track file:// origins by path instead of abusing the unique origin concept

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Chris Evans <scarybeasts at gmail.com>'s
request for review:
Bug 36692: Redo the file:// origin separation
https://bugs.webkit.org/show_bug.cgi?id=36692

Attachment 51809: Track file:// origins by path instead of abusing the unique
origin concept
https://bugs.webkit.org/attachment.cgi?id=51809&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
+ return String("file://") + m_filePath;

This code seems wrong.	This value is exposed to web content.  We want the
current value, not the extended value.

+ if (isLocal() && (m_enforceFilePathSeparation ||
other->m_enforceFilePathSeparation) && m_filePath != other->m_filePath)

This code is copy/pasted.  Whenever you copy/paste code, you should consider
how to abstract it do you don't have to repeat yourself.

Other than that, this looks ok.  Do you want to add a test for the about:blank
that caused us to go down this path?