[webkit-reviews] review granted: [Bug 36481] Web Inspector: Edit Tag Names : [Attachment 51810] [PATCH] Converge on `long` for Inspector* id's

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 26 23:53:35 PDT 2010


Pavel Feldman <pfeldman at chromium.org> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 36481: Web Inspector: Edit Tag Names
https://bugs.webkit.org/show_bug.cgi?id=36481

Attachment 51810: [PATCH] Converge on `long` for Inspector* id's
https://bugs.webkit.org/attachment.cgi?id=51810&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
r+ with comments.

>> This has been bothering me for a long time. Sometimes they are "long", other
times they are "int".

True, it is just that it was not that easy before Yury introduced "long"
setters in the ScriptObject bindings.
Please file a separate bug and land it there.


More information about the webkit-reviews mailing list