[webkit-reviews] review canceled: [Bug 36251] Turn on AUTO_VACUUM for all HTML5 DBs : [Attachment 50988] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 26 19:02:10 PDT 2010


Dumitru Daniliuc <dumi at chromium.org> has canceled Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 36251: Turn on AUTO_VACUUM for all HTML5 DBs
https://bugs.webkit.org/show_bug.cgi?id=36251

Attachment 50988: patch
https://bugs.webkit.org/attachment.cgi?id=50988&action=review

------- Additional Comments from Dumitru Daniliuc <dumi at chromium.org>
Mark, I think this patch is ready for review.

Changes in the latest patch:
1. Fix SQLiteStatement::prepare() to work correctly with sqlite libraries <
3.6.16.
2. Turn on AUTO_VACUUM = 2 for all HTML5 databases.
3. When opening a database, if AUTO_VACUUM != 2, set it to 2 and VACUUM that
database. This is a one-time performance hit per database, which should be
acceptable.
4. Check the number of free pages at the end of every transaction and force a
vacuum only if at least 10% of all pages are free. According to the number
posted in my previous comments, calling PRAGMA incremental_vacuum could take a
non-negligible amount of time; however, the next few operations on that
database should be significantly faster too. In the long run, I believe the
overhead of vacuuming the database when needed should be negligible.


More information about the webkit-reviews mailing list