[webkit-reviews] review granted: [Bug 36620] suppress image failures for now to get a clean test run w/ pixel tests enabled for new-run-webkit-tests : [Attachment 51801] add missing Changelog, add instructions back to the beginning of test_expectations.txt, fix typo

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 26 18:07:06 PDT 2010


David Levin <levin at chromium.org> has granted Dirk Pranke
<dpranke at chromium.org>'s request for review:
Bug 36620: suppress image failures for now to get a clean test run w/ pixel
tests enabled for new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=36620

Attachment 51801: add missing Changelog, add instructions back to the beginning
of test_expectations.txt, fix typo
https://bugs.webkit.org/attachment.cgi?id=51801&action=review

------- Additional Comments from David Levin <levin at chromium.org>
> diff --git a/LayoutTests/platform/mac/test_expectations.txt
b/LayoutTests/platform/mac/test_expectations.txt
>  // -A test cannot be both SLOW and TIMEOUT
>  // -A test can be included twice, but not via the same path.
>  // -If a test is included twice, then the more precise path wins.
> -// -CRASH tests cannot be WONTFIX
> +// -CRASH tests cannot be WONTFIXBUG36620 :
compositing/color-matching/image-color-matching.html = IMAGE

I think you wanted a return here after WONTFIX.


More information about the webkit-reviews mailing list