[webkit-reviews] review denied: [Bug 36620] suppress image failures for now to get a clean test run w/ pixel tests enabled for new-run-webkit-tests : [Attachment 51799] add test_expectations.txt suppressions and fix a bunch of incorrect checksums

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 26 17:59:28 PDT 2010


David Levin <levin at chromium.org> has denied Dirk Pranke
<dpranke at chromium.org>'s request for review:
Bug 36620: suppress image failures for now to get a clean test run w/ pixel
tests enabled for new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=36620

Attachment 51799: add test_expectations.txt suppressions and fix a bunch of
incorrect checksums
https://bugs.webkit.org/attachment.cgi?id=51799&action=review

------- Additional Comments from David Levin <levin at chromium.org>

Needs a ChangeLog.

> diff --git a/LayoutTests/platform/mac/test_expectations.txt
b/LayoutTests/platform/mac/test_expectations.txt
> -// This file consists of lines with specifications of what

I think these instructions are useful.

> +BUG33620: fast/block/positioning/absolute-positioning-no-scrollbar.html =
MISSING

Missing a space.

r- for missing ChangeLog.


More information about the webkit-reviews mailing list