[webkit-reviews] review granted: [Bug 34826] new-run-webkit-tests --platform=mac-leopard does bogus image diffing : [Attachment 51791] revise w/ more feedback from ojan

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 34826: new-run-webkit-tests --platform=mac-leopard does bogus image diffing
https://bugs.webkit.org/show_bug.cgi?id=34826

Attachment 51791: revise w/ more feedback from ojan
https://bugs.webkit.org/attachment.cgi?id=51791&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I'm told that you and Ojan reached a happy place.  This looks OK to me.  I
think this new architecture is much cleaner.

Two letter variable names make my brain kink.  But I don't think it's worth
another round of changes to fix them.  In general I'd rather write out full
english names and phrases to describe variables.  Then again, I come from a
non-80 column limited world. :)

Thanks for all your hard work!