[webkit-reviews] review granted: [Bug 36675] Re-entrant layout via plug-ins may cause crashes with bad RenderWidgets : [Attachment 51780] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 26 14:59:40 PDT 2010


mitz at webkit.org has granted Simon Fraser (smfr) <simon.fraser at apple.com>'s
request for review:
Bug 36675: Re-entrant layout via plug-ins may cause crashes with bad
RenderWidgets
https://bugs.webkit.org/show_bug.cgi?id=36675

Attachment 51780: Patch
https://bugs.webkit.org/attachment.cgi?id=51780&action=review

------- Additional Comments from mitz at webkit.org

> +	   vector before iterating of them, and dref() them at the end. Rather
than checking the m_widgetUpdateSet

Fatal typo: dref().

It’s sad that you can’t use something like RenderWidgetProtector here, but this
seems to be more efficient.


More information about the webkit-reviews mailing list