[webkit-reviews] review granted: [Bug 36063] Upload test result json files to app engine server : [Attachment 51464] Proposed patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Victor Wang <victorw at chromium.org>'s
request for review:
Bug 36063: Upload test result json files to app engine server
https://bugs.webkit.org/show_bug.cgi?id=36063

Attachment 51464: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=51464&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks good.  I'm concerned about lack of testing, but I'm not sure how you'd
test this all.

WebKit would like to use this sort of infrastructure as soon as it's ready.  I
have code in webkit-patch to produce .json files from historical results.html
files from http://build.webkit.org/results  Once the test results server is
ready to actually process those .json files I'm happy to wire up things to
upload them.