[webkit-reviews] review denied: [Bug 36556] CSSPrimitiveValue::cssText() is slow : [Attachment 51634] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Mar 26 13:21:59 PDT 2010
Dave Hyatt <hyatt at apple.com> has denied review:
Bug 36556: CSSPrimitiveValue::cssText() is slow
https://bugs.webkit.org/show_bug.cgi?id=36556
Attachment 51634: Patch
https://bugs.webkit.org/attachment.cgi?id=51634&action=review
------- Additional Comments from Dave Hyatt <hyatt at apple.com>
A number of cases in CSSPrimitiveValue::cssText() do early returns, so you need
to refactor those so that they fall through to the end and actually use the
cache. rect(), attr(), pair all have this problem.
You yanked a FIXME that had useful information in it. Any reason, or just an
accident?
More information about the webkit-reviews
mailing list