[webkit-reviews] review canceled: [Bug 36312] Support viewport meta tag : [Attachment 51666] Patch 1 of 2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 26 09:38:09 PDT 2010


Daniel Bates <dbates at webkit.org> has canceled Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 36312: Support viewport meta tag
https://bugs.webkit.org/show_bug.cgi?id=36312

Attachment 51666: Patch 1 of 2
https://bugs.webkit.org/attachment.cgi?id=51666&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
Updated patch to conform to the related code used in the WebCore-528.15 source
published as part of the iPhone 3.1.3 source code
<http://www.opensource.apple.com/source/WebCore/WebCore-528.15/>.

As far as I can tell from the publicly available source code, the method
Document::processArguments can be made private, so I made this change (David
Kilzer will this cause any issues for you?). I also made various style
corrections so as to conform to the WebKit Code Style Guidelines.

We can further cleanup/refactor this code and add DRT support. I would suggest 
that we do these in separate bugs.

I would appreciate both Maciej Stachowiak's and David Kilzer's feedback
regarding the inclusion of this code into the general WebKit project.


More information about the webkit-reviews mailing list