[webkit-reviews] review denied: [Bug 33696] let's cache nodelists instead of dynamicnodelist::cache : [Attachment 51734] Fixing GC layout test to account for new behaviour

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied anton muhin <antonm at chromium.org>'s
request for review:
Bug 33696: let's cache nodelists instead of dynamicnodelist::cache
https://bugs.webkit.org/show_bug.cgi?id=33696

Attachment 51734: Fixing GC layout test to account for new behaviour
https://bugs.webkit.org/attachment.cgi?id=51734&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> -    [ "document.getElementsByTagName('body')" ], // NodeList
> +    [ "document.getElementsByTagName('body')", "allow custom skip" ], //
NodeList

This says that before the patch we did not allow custom properties on node
lists. And after the patch we do allow custom properties on node lists. That
has nothing to do with caching. Why did this patch have any effect on this?
This makes no sense.

I understand that the caching mean this would change from "allow custom" to
"allow custom skip", but I don't see why this patch changes behavior of adding
a custom property to a node list.