[webkit-reviews] review denied: [Bug 35530] Enum value FORWARD, BACKWARD, RIGHT, LEFT are causing macro conflicts. : [Attachment 51713] Coding style patch.

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Lyon Chen
<lyon.chen at torchmobile.com>'s request for review:
Bug 35530: Enum value FORWARD, BACKWARD, RIGHT, LEFT are causing macro
conflicts.
https://bugs.webkit.org/show_bug.cgi?id=35530

Attachment 51713: Coding style patch.
https://bugs.webkit.org/attachment.cgi?id=51713&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
>  #include "AXObjectCache.h"
>  #include "ApplyStyleCommand.h"
> -#include "CharacterNames.h"
> -#include "CompositionEvent.h"
> -#include "CreateLinkCommand.h"
>  #include "CSSComputedStyleDeclaration.h"
>  #include "CSSMutableStyleDeclaration.h"
>  #include "CSSProperty.h"
>  #include "CSSPropertyNames.h"
>  #include "CSSValueKeywords.h"
> +#include "CharacterNames.h"
>  #include "ClipboardEvent.h"
> +#include "CompositionEvent.h"
> +#include "CreateLinkCommand.h"
>  #include "DeleteButtonController.h"
>  #include "DeleteSelectionCommand.h"
>  #include "DocLoader.h"

This is incorrect. The coding style specifies:

    "#include statements should be in sorted order (case sensitive, as done by
the command-line sort tool or the Xcode sort selection command)."

You have changed them from case sensitive sort order to a different sort order.