[webkit-reviews] review granted: [Bug 36662] Add support for iframe flattening : [Attachment 51741] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Kenneth Rohde Christiansen
<kenneth at webkit.org>'s request for review:
Bug 36662: Add support for iframe flattening
https://bugs.webkit.org/show_bug.cgi?id=36662

Attachment 51741: Patch
https://bugs.webkit.org/attachment.cgi?id=51741&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
Looks good, r=me 

I don't have any really substantial comments just one naming objection:

> -    if (flattenFrameSet())
> +    if (shouldResizeFramesToContent())
>	   positionFramesWithFlattening();

Why this renaming? The naming was discussed quite a bit, lets stick with the
"flatten" terminology now.

You now have shouldResizeFramesToContent() method in both RenderFrameSet and
RenderPartObject (with rather different semantics), even though those are not
really related classes. Why do they need to have same names? Why not stick with
RenderFrameSet::flattenFrameSet() and add RenderPartObject::flattenFrame() or
similar?