[webkit-reviews] review requested: [Bug 36206] Fix the rendering of HTMLProgressElement : [Attachment 51738] Patch v3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 26 07:10:20 PDT 2010


Yael <yael.aharon at nokia.com> has asked	for review:
Bug 36206: Fix the rendering of HTMLProgressElement
https://bugs.webkit.org/show_bug.cgi?id=36206

Attachment 51738: Patch v3
https://bugs.webkit.org/attachment.cgi?id=51738&action=review

------- Additional Comments from Yael <yael.aharon at nokia.com>
Previously, I thought that <progress> element should be simillar to the slider
of <input type="range">, so I used code from RenderSlider, (baselinePosition
and calcPrefWidths).
http://www.whatwg.org/specs/web-apps/current-work/complete.html#the-progress-el
ement-0 specifies the rendering rules for <progress> element, so this patch
fixes that mistake.
This patch also removes code in RenderProgress::updateFromElement() that tries
to optimize the size of the rect to be repainted. The optimization will be
redone later.


More information about the webkit-reviews mailing list