[webkit-reviews] review denied: [Bug 36613] Web Inspector: Cover the Audits panel with tests : [Attachment 51727] [PATCH] Test for the Audits panel + drive-by rule fix

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 36613: Web Inspector: Cover the Audits panel with tests
https://bugs.webkit.org/show_bug.cgi?id=36613

Attachment 51727: [PATCH] Test for the Audits panel + drive-by rule fix
https://bugs.webkit.org/attachment.cgi?id=51727&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
> +<!-- These scripts are needed to result in a violation of the max JS file
count from the same domain -->

You should put artificial scripts into the resources folder for this test
instead.
 
> +	       frontend_assertEquals("'" + ruleResult.value + "' violation
count", expectedData[ruleResult.value], ruleResult.violationCount);

You should push information back to the inspected page instead and dump it onto
the screen. That way expectations would reflect what is happening in the test.