[webkit-reviews] review granted: [Bug 36586] [Chromium-Win] websocket_server.py failed to start : [Attachment 51617] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 26 00:51:31 PDT 2010


Shinichiro Hamaji <hamaji at chromium.org> has granted Fumitoshi Ukai
<ukai at chromium.org>'s request for review:
Bug 36586: [Chromium-Win] websocket_server.py failed to start
https://bugs.webkit.org/show_bug.cgi?id=36586

Attachment 51617: Patch
https://bugs.webkit.org/attachment.cgi?id=51617&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
Looks good! But please add a few more information into ChangeLog before you
submit.

> +	   * Scripts/webkitpy/layout_tests/port/websocket_server.py: open
os.devnull for stdin

It would be better to describe why this change fixes the issue.


More information about the webkit-reviews mailing list