[webkit-reviews] review granted: [Bug 36562] [Chromium] Implement WebFormControlElement and WebSelectElement : [Attachment 51686] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 25 23:16:16 PDT 2010
Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted James Hawkins
<jhawkins at chromium.org>'s request for review:
Bug 36562: [Chromium] Implement WebFormControlElement and WebSelectElement
https://bugs.webkit.org/show_bug.cgi?id=36562
Attachment 51686: Patch
https://bugs.webkit.org/attachment.cgi?id=51686&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebKit/chromium/public/WebFormControlElement.h
...
> + WebFormControlElement& operator=(const WebFormControlElement& e) {
WebElement::assign(e); return *this; }
The style bot is saying that this should be rewritten as:
WebFormControlElement& operator=(const WebFormControlElement& e)
{
WebElement::assign(e);
return *this;
}
R=me otherwise
More information about the webkit-reviews
mailing list