[webkit-reviews] review granted: [Bug 36520] [DRT/Chromium] Add LayoutTestController : [Attachment 51600] Proposed patch (rev.3)

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted TAMURA, Kent
<tkent at chromium.org>'s request for review:
Bug 36520: [DRT/Chromium] Add LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=36520

Attachment 51600: Proposed patch (rev.3)
https://bugs.webkit.org/attachment.cgi?id=51600&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
I am ok with checking this in as-is as long as we all understand this is far
from final and is going in because we want to have something running to hack
on. Please spread FIXMEs liberally and start filing bugs, so that we don't
forget. Nate and I did this for V8 bindings refactoring, and it worked out
really well
(https://bugs.webkit.org/showdependencytree.cgi?id=32630&hide_resolved=0).

We will need to get rid of direct base dependencies, and convert all
std::string uses to WebString, and remove STL use.

On GURL::Resolve, we may have to poke this method through WebURL wrapper.

> +    if (!m_queue.isEmpty()) {
> +	   // We delay processing queued work to avoid recursion problems.
> +	   m_timer.Start(base::TimeDelta(), this, &WorkQueue::processWork);

How did base/time squeak by here?