[webkit-reviews] review granted: [Bug 25195] mouse-based selections are always directional on Window/Linux : [Attachment 51663] Patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 25195: mouse-based selections are always directional on Window/Linux
https://bugs.webkit.org/show_bug.cgi?id=25195

Attachment 51663: Patch
https://bugs.webkit.org/attachment.cgi?id=51663&action=review

------- Additional Comments from David Levin <levin at chromium.org>

> diff --git a/LayoutTests/editing/selection/extend-after-mouse-selection.html
b/LayoutTests/editing/selection/extend-after-mouse-selection.html
> +
> +    // On Win/Linux the anchor is be fixed after the mouse-selection and
never changes.
> +    // On Mac, the first character-granularity selection after a
mouse-selection resets the anchor/focus.
> +    if (onMacPlatform)
> +	 assertSelectionAt(endTarget.firstChild, 2,
startTarget.previousSibling, 1);
> +    else
> +	 assertSelectionAt(startTarget.firstChild, 0, endTarget.firstChild, 1);


> +    if (onMacPlatform)
> +	 assertSelectionAt(endTarget.firstChild, 2, startTarget.firstChild, 0);

> +    else
> +	 assertSelectionAt(startTarget.firstChild, 0, endTarget.firstChild, 2);

> +

Style for the js test is lax, but it bothers me that the 2 space indent used in
the new code is inconsistent with the rest of the file. Please consider
adjusting this to be 4 spaces.