[webkit-reviews] review granted: [Bug 36606] Web Inspector: Short Records filter sould be implemented in Timeline Panel : [Attachment 51659] [patch] second iteration.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 25 11:10:31 PDT 2010
Pavel Feldman <pfeldman at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 36606: Web Inspector: Short Records filter sould be implemented in Timeline
Panel
https://bugs.webkit.org/show_bug.cgi?id=36606
Attachment 51659: [patch] second iteration.
https://bugs.webkit.org/attachment.cgi?id=51659&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
> + while (record._isLongEvent() && record.parent &&
!record.parent._isLongEvent()) {
> + record = record.parent;
No need to call _isLongEvent twice on the same record. I can optimize it while
landing.
I'll land manually.
More information about the webkit-reviews
mailing list