[webkit-reviews] review granted: [Bug 36565] [v8] Error in getScriptExecutionContext() when worker context is terminating : [Attachment 51653] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 25 10:42:50 PDT 2010


Nate Chapin <japhet at chromium.org> has granted Andrew Wilson
<atwilson at chromium.org>'s request for review:
Bug 36565: [v8] Error in getScriptExecutionContext() when worker context is
terminating
https://bugs.webkit.org/show_bug.cgi?id=36565

Attachment 51653: Patch
https://bugs.webkit.org/attachment.cgi?id=51653&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
Ok.

Is there any reason for us to leave a shortcut in place for getting the
WorkerContextExecutionProxy* with a single call (for the cases where "we're not
in a worker context" and "we're shutting down" are handled equivalently)?  My
guess is that it would just create confusion, but I'll ask your opinion anyway.
:)


More information about the webkit-reviews mailing list