[webkit-reviews] review granted: [Bug 36597] [v8] Add if ENABLE guard for Worker specific code. : [Attachment 51639] Patch number 1

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Kristian Monsen
<kristianm at google.com>'s request for review:
Bug 36597: [v8] Add if ENABLE guard for Worker specific code.
https://bugs.webkit.org/show_bug.cgi?id=36597

Attachment 51639: Patch number 1
https://bugs.webkit.org/attachment.cgi?id=51639&action=review

------- Additional Comments from David Levin <levin at chromium.org>
> Index: WebCore/ChangeLog
> +2010-03-25  Kristian Monsen	<kristianm at google.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Guarding the function in the header as well.

I'll r+ *but* before committing the patch this line should be changed to the
(new) title of the bug (a WK committer can do this for you right before they
commit the change and I think you have a few nearby).

The problem is that right now this line doesn't tell you anything. Ideally one
should be able to read this and get a sense of what was addressed (so folks can
decide to look at the details or not -- think of it like a good email subject).